fix(e2e tests): missing new eigenda-client required config fields #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thrpc and svcmanageraddr
…uest_target (#153)" This reverts commit 15b10fd. The commit was doing things very wrong. I hadn't understood how pull_request_target works. Was causing the workflow to run against main branch head commit instead of PR commit. We will need to find another solution to the problem of letting external contributors run this workflow.
epociask
previously approved these changes
Oct 30, 2024
samlaf
dismissed
epociask’s stale review
Found a regression whcih is causing the bug.. will need to update: Layr-Labs/eigenda#849
This forces test runner to be fully aware of which test suite he is running (otherwise it implicitly runs the TESTNET suite)
Previously it was printing as byte array, which is unreadable and clutters logs
TODO: will need to update this after that PR is merged
samlaf
commented
Oct 30, 2024
go.mod
Outdated
Comment on lines
8
to
10
| // TODO: merge https://github.com/Layr-Labs/eigenda/pull/849 first | ||
| // and then update this dep to the merged commit. | ||
| github.com/Layr-Labs/eigenda v0.8.5-0.20241030205712-b301232f7804 |
5 tasks
Just merged Layr-Labs/eigenda#849 which will fix our ci bug
|
Merged the upstream Layr-Labs/eigenda#849, and updated eigenda dep to eigenda master head. Merging without waiting to unblock here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was missing ethrpc and svcmanageraddr
Also realized
pull_request_targetwas super wrong...... reverted that commit.pull_request_target by default checks out the target branch! so all the tests were being done against main branch and not the PR branch..
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers